docs(cronicle): sync playground coverage#335
Merged
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughA single-line addition to ChangesPlayground Config Mapping
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
mberlofa
added a commit
to helmforgedev/charts
that referenced
this pull request
Jul 6, 2026
## Summary - add centralized cronicle values validation through templates/validate.yaml - add helm-unittest coverage for secret, ingress, and selector-label guardrails - preserve hostless catch-all Ingress rendering by omitting spec.rules[].host when unset ## Validation - make template-standards-check CHART=cronicle - helm unittest charts/cronicle - helm lint --strict charts/cronicle - make standards-check CHART=cronicle - make validate-chart CHART=cronicle TIMEOUT=900: FULLY VALIDATED (12 layers) - make site-sync-check CHART=cronicle - make release-check REPO=charts - make attribution-check REPO=charts Site PR: helmforgedev/site#335 Issue: #633 <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **New Features** * Added render-time chart validation to fail fast on invalid configuration (e.g., missing required secret settings, missing Ingress hosts, and conflicting pod label configuration). * Added support for “hostless” Ingress rules by omitting the `host` field when no host is provided. * **Bug Fixes** * Prevented `podLabels` from overriding the chart’s selector label keys. * **Tests** * Added Ingress coverage for hostless catch-all behavior. * Added a validation test suite for both passing and failing scenarios. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: MergeCheck <mergecheck@example.invalid>
mberlofa
force-pushed
the
docs/cronicle-template-standards-sync
branch
from
e68c6fd to
744bf24
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
Chart PR: helmforgedev/charts#656
Issue: helmforgedev/charts#633
Summary by CodeRabbit
croniclechart in the playground’s sync/config selection, making it available alongside other eligible chart slugs.